Change in vdsm[master]: Adding remove\disable verbs to vdsm-tool for admin usages

Alon Bar-Lev alonbl at redhat.com
Tue Feb 25 20:46:52 UTC 2014


Alon Bar-Lev has posted comments on this change.

Change subject: Adding remove\disable verbs to vdsm-tool for admin usages
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/21772/2/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 357:     m = [
Line 358:         c.getName() for c in __configurers
Line 359:         if c.getName() in args.modules and not c.removeConf()
Line 360:     ]
Line 361:     if m:
> I don't see understand. what do we change an object status here?
c.removeConf()
Line 362:         sys.stdout.write(
Line 363:             "Could not remove configuration for modules %s\n" % ','.join(m),
Line 364:         )
Line 365:         ret = False


-- 
To view, visit http://gerrit.ovirt.org/21772
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7f2c031436a6d202f856c24d9c9420c8bfdf6df
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list