Change in vdsm[master]: vm: report migration progress in VmStats

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Tue Feb 25 11:53:59 UTC 2014


Michal Skrivanek has posted comments on this change.

Change subject: vm: report migration progress in VmStats
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/24465/3/vdsm/vm.py
File vdsm/vm.py:

Line 140:         """
Line 141:         Get the status of the migration.
Line 142:         """
Line 143:         if self._monitorThread is not None:
Line 144:             # fetch migration status from the monitor thread
I believe the calculation is wrong. Please address in a separate patch
Line 145:             self.status['progress'] = int(
Line 146:                 float(self._monitorThread.data_progress +
Line 147:                       self._monitorThread.mem_progress) / 2)
Line 148:         return self.status


-- 
To view, visit http://gerrit.ovirt.org/24465
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35e40663921b2d73a9b49727c61b8b1f4dacdb9a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list