Change in vdsm[master]: caps: Collect numa information
fromani at redhat.com
fromani at redhat.com
Tue Feb 25 09:37:39 UTC 2014
Francesco Romani has posted comments on this change.
Change subject: caps: Collect numa information
......................................................................
Patch Set 6: Code-Review-1
(2 comments)
something is missing in the vdsmapi-schema.json
http://gerrit.ovirt.org/#/c/23703/6/vdsm/caps.py
File vdsm/caps.py:
Line 188: def _getMemoryStatsByNumaCell(cell, flags=0, memStats=None):
Line 189: if memStats is None:
Line 190: memStats = libvirtconnection.get().getMemoryStats(int(cell), flags)
Line 191: if type(memStats) is frozenset:
Line 192: memStats = dict(memStats)
I think we can just call dict() here.
What happens if memStats is not a frozenset (maybe plain set)?
Line 193: return memStats
Line 194:
Line 195:
Line 196: @utils.memoized
http://gerrit.ovirt.org/#/c/23703/6/vdsm_api/vdsmapi-schema.json
File vdsm_api/vdsmapi-schema.json:
Line 1033: 'emulatedMachines': ['str'], 'ISCSIInitiatorName': 'str',
Line 1034: 'HBAInventory': 'HbaInventory', 'vmTypes': ['VmType'],
Line 1035: 'memSize': 'uint', 'reservedMem': 'uint',
Line 1036: 'guestOverhead': 'uint', 'netConfigDirty': 'bool',
Line 1037: 'rngSources': ['VmRngDeviceSource'], 'numaNodes': 'NumaNodeMap'}}
This needs to be documented in the schema, I expect the schema compilation fail here otherwise.
Line 1038:
Line 1039: ##
Line 1040: # @Host.getCapabilities:
Line 1041: #
--
To view, visit http://gerrit.ovirt.org/23703
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63eeb697ab986c3b9cad0dc44f41924f329e52cd
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi at hp.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa at eldorado.org.br>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi at eldorado.org.br>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.lima at eldorado.org.br>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi at hp.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list