Change in vdsm[master]: vdsClient: file based mechanism to provide password

Alon Bar-Lev alonbl at redhat.com
Mon Feb 24 15:42:34 UTC 2014


Alon Bar-Lev has posted comments on this change.

Change subject: vdsClient: file based mechanism to provide password
......................................................................


Patch Set 10:

completely untested, but attempting to reduce ping-pong, I wrote the implementation I would like to see.

take this as a base and make it work.

it should add additional args fields to command and parse them using same method we agreed.

previous implementation tries to fuzzy match auth= anywhere, which is wrong.

thanks!

-- 
To view, visit http://gerrit.ovirt.org/24733
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I363a16e6a7872ca05e19d5f520bdba90fb492374
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list