Change in vdsm[master]: vmDevices: add mechanism to persist vmDevice defaults
Federico Simoncelli
fsimonce at redhat.com
Mon Feb 24 11:14:11 UTC 2014
Federico Simoncelli has posted comments on this change.
Change subject: vmDevices: add mechanism to persist vmDevice defaults
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
I'd like to see _defaults being renamed.
http://gerrit.ovirt.org/#/c/21066/3/vdsm/vm.py
File vdsm/vm.py:
Line 1249: pass
Line 1250: self.conf = conf
Line 1251: self.log = log
Line 1252: self._deviceXML = None
Line 1253: self._defaults()
Can we rename this to something like: _initializeDefaults(...) or something better.
Line 1254:
Line 1255: def _defaults(self):
Line 1256: pass
Line 1257:
--
To view, visit http://gerrit.ovirt.org/21066
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc8383cbce78490c8dfab1c253883a06459f1547
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list