Change in vdsm[master]: vm: cleanup post-libvirt merge code

fromani at redhat.com fromani at redhat.com
Mon Feb 24 09:42:25 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: vm: cleanup post-libvirt merge code
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/24744/3/vdsm/vm.py
File vdsm/vm.py:

Line 3714:         # we need a way to
Line 3715:         # 1. detect ENOSPC when connected to a VM.
Line 3716:         # 2. detect a VM was paused to ENOSPC when reconnecting after
Line 3717:         #    a VDSM restart.
Line 3718:         # upstream libvirt unfortunately lacks both features.
> Would you open a libvirt RFE on this on bugzilla, and mention it here? Othe
Already done: https://bugzilla.redhat.com/show_bug.cgi?id=1067414

I was not sure it was OK to mention the BZ in the comment, but I'll add.

Also, I was not sure this should be a RFE because the code is present but currently disabled. The mandatory search before to open the bug did not produced any duplicate.
Line 3719:         self.log.warning('_readPauseCode unsupported by libvirt vm')
Line 3720:         return 'NOERR'
Line 3721: 
Line 3722:     def _timeoutExperienced(self, timeout):


-- 
To view, visit http://gerrit.ovirt.org/24744
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29e8a888d124fccd878a2ecac30734e58b355678
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list