Change in vdsm[master]: xmlrpc: Support HTTP 1.1

nsoffer at redhat.com nsoffer at redhat.com
Mon Feb 24 08:34:54 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: xmlrpc: Support HTTP 1.1
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.ovirt.org/#/c/24294/6//COMMIT_MSG
Commit Message:

Line 16: methods are used only on Python 2.6. Python 2.7 already include these
Line 17: changes. Then the protocol_version is set to HTTP/1.1, enabling
Line 18: automatic keep-alive.
Line 19: 
Line 20: A new configuration option "xmlrpc_http11" can be used to disbale this
> Configuration options are evil. I'm being over-dramatic, but they put the b
Using HTTP/1.1, the server threads are long living, and each thread handle multiple requests (1000's), instead of one. This means that bugs in the old code that were hidden by death of the single thread per request, may be revealed now.

If we have such bug, having an option to disable long living threads and means that a user have quick way to fix things, until we fix the real bug. I think this is a more careful way to introduce new features.
Line 21: feature and use HTTP/1.0 as used before.
Line 22: 
Line 23: We can see in the logs that only few threads are created now for service
Line 24: XMLRPC requests, and most requests are handled by the same thread.


-- 
To view, visit http://gerrit.ovirt.org/24294
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie033d5c53c81c8db99d5c26697a1727be030e0b4
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list