Change in vdsm[master]: [WIP] lvm: Add an option to replace locking type 4
ykaplan at redhat.com
ykaplan at redhat.com
Sun Feb 23 12:08:44 UTC 2014
Yeela Kaplan has posted comments on this change.
Change subject: [WIP] lvm: Add an option to replace locking type 4
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.ovirt.org/#/c/23645/2/vdsm/storage/lvm.py
File vdsm/storage/lvm.py:
Line 256: self._filterStale = False
Line 257:
Line 258: return self._extraCfg
Line 259:
Line 260: def _addExtraCfg(self, cmd, devices=tuple(), safe):
> Safe should have a default value or be before devices.
Was done in a later patch when testing,
will move it here. thanks.
Line 261: newcmd = [constants.EXT_LVM, cmd[0]]
Line 262: if devices:
Line 263: conf = _buildConfig(devices)
Line 264: else:
Line 291: self._pvs = {}
Line 292: self._vgs = {}
Line 293: self._lvs = {}
Line 294:
Line 295: def cmd(self, cmd, devices=tuple(), safe=True):
> May be better (TM) to change safe=True for lvm cluster safe commands?
In my point of view,
safe stands for :
safe mode == default config of the host
unsafe mode == we allow locking type 1 for cluster safe commands...
If you think it's critical then I can change it.
Line 296: """
Line 297: Use safe as False only for lvm cluster safe commands.
Line 298: These are cmds that don't change metadata of an existing VG.
Line 299: """
--
To view, visit http://gerrit.ovirt.org/23645
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a67a7fa20145763d8ab5cdbf293a9c3eb070067
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list