Change in vdsm[master]: vdsClient: file based mechanism to provide password

ybronhei at redhat.com ybronhei at redhat.com
Sun Feb 23 08:37:28 UTC 2014


Yaniv Bronhaim has posted comments on this change.

Change subject: vdsClient: file based mechanism to provide password
......................................................................


Patch Set 7:

(4 comments)

http://gerrit.ovirt.org/#/c/24733/7//COMMIT_MSG
Commit Message:

Line 12:  
Please consider :

The patch implements new alternatives to provide command's password value instead of a plain text. The new API format for the password authentication field is changed to auth=[alt:value]

and the title can be changed respectively


http://gerrit.ovirt.org/#/c/24733/7/client/vdsClient.py
File client/vdsClient.py:

Line 145: Exception
use RuntimeError and add traceback or the method value to the print


Line 766:             key, value = item.split('=')
Line 767:             if key == 'auth':
Line 768:                 key = 'password'
Line 769:                 value = getPassword(item)
Line 770:             con[key] = value
just con['password'] = value, when do you change the key param? its redundant and odd
Line 771:         conList.append(con)
Line 772:         res = self.s.validateStorageServerConnection(serverType,
Line 773:                                                      spUUID, conList)
Line 774:         if res['status']['code']:


Line 2147: password
use constant for this string. if you'll have new alternative or typo, you prefer to fix it in one location


-- 
To view, visit http://gerrit.ovirt.org/24733
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I363a16e6a7872ca05e19d5f520bdba90fb492374
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list