Change in vdsm[master]: vdsClient: file based mechanism to provide password
Alon Bar-Lev
alonbl at redhat.com
Fri Feb 21 15:08:33 UTC 2014
Alon Bar-Lev has posted comments on this change.
Change subject: vdsClient: file based mechanism to provide password
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/24733/6/client/vdsClient.py
File client/vdsClient.py:
Line 367: print response['status']['message']
Line 368: sys.exit(response['status']['code'])
Line 369:
Line 370: def do_setVmTicket(self, args):
Line 371: if args[-1].startswith('auth'):
> We want to get last element. As you can see this command is good example ho
I thought the last element is a set of options to allow us to add more in future without having the same issue we are in now, this is why we have auth= there and not plain password format.
you should split by ',' and look for auth=, we should also support escaping within password to enable any character there.
Line 372: otp64 = getPassword(args[-1][5:])
Line 373: if len(args) == 3:
Line 374: vmId, secs = args[:2]
Line 375: connAct = 'disconnect'
--
To view, visit http://gerrit.ovirt.org/24733
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I363a16e6a7872ca05e19d5f520bdba90fb492374
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list