Change in vdsm[master]: vdsm-reg: eliminate the VDSMBRIDGE macro

danken at redhat.com danken at redhat.com
Fri Feb 21 11:57:55 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm-reg: eliminate the VDSMBRIDGE macro
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/24814/1/vdsm_reg/deployUtil.py.in
File vdsm_reg/deployUtil.py.in:

Line 85: ERR_NO_ROUTE = 7
Line 86: SCRIPT_NAME_ADD = "addNetwork"
Line 87: SCRIPT_NAME_DEL = "delNetwork"
Line 88: IFACE_CONFIG = "/etc/sysconfig/network-scripts/ifcfg-"
Line 89: MGT_BRIDGE_NAME = "ovirtmgmt"
> Will this variable be changed by a downstream patch? It makes sense to do s
yes. It would keep the downstream patch more localized to the legacy code than now (when it patches configure.ac)
Line 90: REMOTE_SSH_KEY_FILE = ('/engine.ssh.key.txt',)
Line 91: CORE_DUMP_PATH = '/var/lib/vdsm/core'
Line 92: CORE_PATTERN = '/proc/sys/kernel/core_pattern'
Line 93: XML_QUOTES = {


-- 
To view, visit http://gerrit.ovirt.org/24814
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa1dae084ae9df44c10e0f6ae43584544dab2b8d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list