Change in vdsm[master]: confNet: ifcfg's VLAN should be set only on vlan cfg

danken at redhat.com danken at redhat.com
Thu Feb 20 15:58:08 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: confNet: ifcfg's VLAN should be set only on vlan cfg
......................................................................


confNet: ifcfg's VLAN should be set only on vlan cfg

If a misguided script calls addNetwork with explicit VLAN option, it
should not be blindly copied to the top-most device.
We set VLAN=yes on the ifcfg script for the vlan device, and that's
that.

This is a very limited hack of a wider problem: unrecognized network
options are copied to the bridge's ifcfg file.

Bug-Url: https://bugzilla.redhat.com/1051150
Change-Id: Ia2c9d6c86e73104424ca8ac901bf09e4b98a47ab
Signed-off-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/7411
Reviewed-by: Antoni Segura Puimedon <asegurap at redhat.com>
---
M vdsm/netconf/ifcfg.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Antoni Segura Puimedon: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/7411
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia2c9d6c86e73104424ca8ac901bf09e4b98a47ab
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>


More information about the vdsm-patches mailing list