Change in vdsm[master]: Fix in testLeakFd to avoid potential races during the check

nsoffer at redhat.com nsoffer at redhat.com
Thu Feb 20 15:49:22 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: Fix in testLeakFd to avoid potential races during the check
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/24739/1/tests/miscTests.py
File tests/miscTests.py:

Line 978:     def testLeakFd(self):
Line 979:         """
Line 980:         Make sure that nothing leaks
Line 981:         """
Line 982:         import gc
Please import gc in the module level so it is clear that we have this dependency.
Line 983:         openFdNum = lambda: len(misc.getfds())
Line 984:         gc.collect()
Line 985:         openFds = openFdNum()
Line 986:         self.testStdOut()


-- 
To view, visit http://gerrit.ovirt.org/24739
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6a6e0586c3e225771701cd594f485aae9b00b6e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list