Change in vdsm[master]: vm: make new timekeeping revertable

danken at redhat.com danken at redhat.com
Thu Feb 20 13:48:19 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: vm: make new timekeeping revertable
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/24443/2/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:

Line 193:         ('transient_disks_repository', '@VDSMLIBDIR@/transient',
Line 194:             'Local path to the transient disks repository.'),
Line 195: 
Line 196:         ('kvm_specific_timekeeping', 'true',
Line 197:             'Enable the best KVM time keeping settings;'
sorry for worrying about the name, but if we were 100% sure that what we use is the "best", we would not need this configurable. Also, "pit" is not kvm-specific. Plain qemu has it, I suppose.

maybe have

  legacy_timekeeping_ovirt_3.0 = false

?
Line 198:             ' disable to revert to legacy QEMU settings'),
Line 199:     ]),
Line 200: 
Line 201:     # Section: [ksm]


-- 
To view, visit http://gerrit.ovirt.org/24443
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I471be44454dcae6e73c46a473eb1eee19a5275ab
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.lima at eldorado.org.br>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list