Change in vdsm[master]: vdsClient: file based mechanism to provide password

Alon Bar-Lev alonbl at redhat.com
Thu Feb 20 13:44:58 UTC 2014


Alon Bar-Lev has posted comments on this change.

Change subject: vdsClient: file based mechanism to provide password
......................................................................


Patch Set 3:

you wanted to keep backward compatibility, so password should have some value but ignored if auth= is specified, we should use '-' as a place holder in doc.

 <vmId> <sec> [disconnect|keep|fail] [params={}] auth=what:value

Please be consistent... use auth= with what:value as well.

 id=<id>,connection=<path>,portal=<portal>,port=<port>,iqn=<iqn>,user=<username>,password|password-file|password-env=<password | value>

-- 
To view, visit http://gerrit.ovirt.org/24733
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I363a16e6a7872ca05e19d5f520bdba90fb492374
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list