Change in vdsm[master]: vdsClient: file based mechanism to provide password

Alon Bar-Lev alonbl at redhat.com
Thu Feb 20 08:32:04 UTC 2014


Alon Bar-Lev has posted comments on this change.

Change subject: vdsClient: file based mechanism to provide password
......................................................................


Patch Set 1: Code-Review-1

Hi,

There is no need for base64.

CLI should support the following options, by order (first wins):

1. get password from cli
a. file, the file should contain plain password.
b. argument, weak, encouraged but we do not enforce our-selves.

2. get password from environment.

3. get password interactively (optional).

See a simple example at[1].

I kinda like the openssl[2] solution... to use --xxxx=file:xxx --xxxx=pass:xxx --xxxx=env:xxx but not that important, we can have two arguments.

Anyway, the base64 is not required.

Thanks!

[1] http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=blob;f=packaging/bin/engine-backup.sh;hb=HEAD#l74
[2] https://www.openssl.org/docs/apps/openssl.html

-- 
To view, visit http://gerrit.ovirt.org/24733
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I363a16e6a7872ca05e19d5f520bdba90fb492374
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list