Change in vdsm[master]: Using egrep when greping conf files
danken at redhat.com
danken at redhat.com
Wed Feb 19 14:50:52 UTC 2014
Dan Kenigsberg has posted comments on this change.
Change subject: Using egrep when greping conf files
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/24741/1/lib/vdsm/tool/libvirt_configure.sh.in
File lib/vdsm/tool/libvirt_configure.sh.in:
Line 46:
Line 47: get_libvirt_conf_item() {
Line 48: local cfile="$1"
Line 49: local key="$2"
Line 50: @EGREP_PATH@ "^\s*"${key}"\s*=" "${cfile}" | \
using -E would be nicer than requiring another executable.
Line 51: tail -1 | @SED_PATH@ "s/\s*$key\s*=\s*//;s/\s*\(#.*\)\?$//"
Line 52: }
Line 53:
Line 54: test_conflicting_conf() {
--
To view, visit http://gerrit.ovirt.org/24741
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf63316f4cec2ade80a6259a8ceb5b80f2537040
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list