Change in vdsm[master]: vm: set self._dom to None after destroying vm

fromani at redhat.com fromani at redhat.com
Wed Feb 19 12:04:25 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: vm: set self._dom to None after destroying vm
......................................................................


Patch Set 3: Code-Review+1

For some reasons -likely just irrational- I don't really like to reset _dom this way, but on the other hand I can't see any mistake in the patch, and the issue addressed here is real. So, I'll just keep the discussion purely technical, and on this basis and I'm ok with the patch.

-- 
To view, visit http://gerrit.ovirt.org/23014
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4eca4c14e44a2a95628bf8e45a7a0a64d56446b8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Jarod.w <work.iec23801 at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jarod.w <work.iec23801 at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list