Change in vdsm[master]: Makefile.am: create vdsm logs on make install

danken at redhat.com danken at redhat.com
Wed Feb 19 11:04:54 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: Makefile.am: create vdsm logs on make install
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

you should also remove the relevant lines from the spec's %install section.

http://gerrit.ovirt.org/#/c/23882/1/vdsm/Makefile.am
File vdsm/Makefile.am:

Line 166: 	$(MKDIR_P) $(DESTDIR)$(vdsmlibdir)/persistence
Line 167: 	$(MKDIR_P) $(DESTDIR)$(vdsmlibdir)/upgrade
Line 168: 	$(MKDIR_P) $(DESTDIR)$(vdsmbackupdir)
Line 169: 	$(MKDIR_P) $(DESTDIR)$(localstatedir)/lib/libvirt/qemu/channels
Line 170: 	touch $(DESTDIR)$(vdsmlogdir)/{metadata.log,mom.log,supervdsm.log,vdsm.log}
It would be nicer to define a macro, rather than repeat the file names 3 times.
Line 171: 	chmod 0644 $(DESTDIR)$(vdsmlogdir)/{metadata.log,mom.log,supervdsm.log,vdsm.log}
Line 172: 	chown $(VDSMUSER):$(VDSMGROUP) $(DESTDIR)$(vdsmlogdir)/{metadata.log,mom.log,vdsm.log}
Line 173: 	chown root:root $(DESTDIR)$(vdsmlogdir)/supervdsm.log
Line 174: 


-- 
To view, visit http://gerrit.ovirt.org/23882
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7f5dc4ca01fecddc5226255e37b0bab68b8c479f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list