Change in vdsm[master]: sampling: avoid needless modulu

danken at redhat.com danken at redhat.com
Tue Feb 18 22:55:44 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: sampling: avoid needless modulu
......................................................................


sampling: avoid needless modulu

Since Linux jiffies counters wrap at 32 bits, we take modulu 2 ** 32
when we calculate the difference between two consecustive samples.
Taking another modulu, after dividing by the time interval, is harmless
but also needless and confusing.

Change-Id: I31ec567836a4c9b59c113eff45e4baa653e399fa
Signed-off-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/24193
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
---
M vdsm/sampling.py
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/24193
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I31ec567836a4c9b59c113eff45e4baa653e399fa
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: David Caro <dcaroest at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list