Change in vdsm[ovirt-3.4]: Fix defaultRoute handling

ybronhei at redhat.com ybronhei at redhat.com
Tue Feb 18 16:49:18 UTC 2014


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: Fix defaultRoute handling
......................................................................


Fix defaultRoute handling

defaultRoute wasn't being past correctly to objectivizeNetwork,
so that defaultRoute was always None inside the function,
no matter what was past to it.

This meant that DEFROUTE=yes/no was never written to ifcfg files,
and 'ip route add default...' never applied by the iproute2
configurator.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1015009

Change-Id: I643c5fe9dab39833d73541b7a1bfaae9ae3e749d
Signed-off-by: Assaf Muller <amuller at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/24631
Reviewed-by: Antoni Segura Puimedon <asegurap at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Tested-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/24677
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
---
M vdsm/configNetwork.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Yaniv Bronhaim: Looks good to me, approved
  Assaf Muller: Verified; Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/24677
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I643c5fe9dab39833d73541b7a1bfaae9ae3e749d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list