Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults

danken at redhat.com danken at redhat.com
Tue Feb 18 14:44:26 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: netinfo: Retrieve bonding options differing from defaults
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.ovirt.org/#/c/24456/5/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:

Line 575: 
Line 576: def _bondinfo(link, ipaddrs):
Line 577:     info = _devinfo(link, ipaddrs)
Line 578:     info.update({'hwaddr': link.address, 'slaves': slaves(link.name),
Line 579:                  'options': _getBondingOptions(link)})
you should also overwrite ['cfg']['BONDING_OPTS'] - older Engines depend on it.
Line 580:     return info
Line 581: 
Line 582: 
Line 583: def _vlaninfo(link, ipaddrs):


-- 
To view, visit http://gerrit.ovirt.org/24456
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list