Change in vdsm[master]: test: unstable jsonrpc tests

danken at redhat.com danken at redhat.com
Tue Feb 18 13:28:22 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: test: unstable jsonrpc tests
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/24624/1//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2014-02-18 11:06:32 +0100
Line 6: 
Line 7: test: unstable jsonrpc tests
Line 8: 
Line 9: I am not sure whether this will fix test instability because I am not
Your commit message should state which instability you are trying to fix. In any case, another instability is still here:

======================================================================
FAIL: testLeakFd (miscTests.WatchCmd)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/jenkins/workspace/vdsm_unit_tests_gerrit/vdsm/tests/miscTests.py", line 988, in testLeakFd
    self.assertEquals(openFdNum(), openFds)
AssertionError: 78 != 79
-------------------- >> begin captured logging << --------------------
Line 10: able to recreate it (saw only one failure in jenkins history). The ssl
Line 11: flag was not passed to constructReactor so plain tcp reactors were
Line 12: reused which might caused the issue.
Line 13: 


-- 
To view, visit http://gerrit.ovirt.org/24624
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb6dfa4d6324baa0b7091ad6713854d146ec999d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list