Change in vdsm[master]: Fix defaultRoute handling

masayag at redhat.com masayag at redhat.com
Tue Feb 18 11:09:43 UTC 2014


Moti Asayag has posted comments on this change.

Change subject: Fix defaultRoute handling
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/24631/2/vdsm/configNetwork.py
File vdsm/configNetwork.py:

Line 278: 
Line 279:     netEnt = objectivizeNetwork(network if bridged else None, vlan, bonding,
Line 280:                                 bondingOptions, nics, mtu, ipaddr, netmask,
Line 281:                                 gateway, bootproto, ipv6addr, ipv6gateway,
Line 282:                                 defaultRoute=defaultRoute, _netinfo=_netinfo,
Perhaps it would be more clear to provide None for the ipv6addr and ipv6gateway from the IPv4 initialization, so we reduce the mixture which caused this confusion initially ?
Line 283:                                 configurator=configurator, **options)
Line 284: 
Line 285:     netEnt.configure(**options)
Line 286:     configurator.configureLibvirtNetwork(network, netEnt,


-- 
To view, visit http://gerrit.ovirt.org/24631
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I643c5fe9dab39833d73541b7a1bfaae9ae3e749d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list