Change in vdsm[master]: sp: Remove invalid validation of stale meta data

nsoffer at redhat.com nsoffer at redhat.com
Mon Feb 17 14:31:21 UTC 2014


Nir Soffer has uploaded a new change for review.

Change subject: sp: Remove invalid validation of stale meta data
......................................................................

sp: Remove invalid validation of stale meta data

When refreshing a storage pool, we used to validate the the metadata
before refreshing the pool. This validation fail if the storage domain
was just upgraded from old format where metadata was storaged on the
medadata lv, to the new format keeping metadata in the lv tags.

The validation is pefromed now after the refresh, ensuring that the
metadata is correct after a successful refresh.

Change-Id: I27ab243a03f23b1155867f2eeec98b1481b5b72d
Bug-Url: https://bugzilla.redhat.com/954169
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
---
M vdsm/storage/hsm.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/68/24568/1

diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index d6d0715..5720b17 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -872,8 +872,8 @@
         pool = self.getPool(spUUID)
 
         try:
-            self.validateSdUUID(msdUUID)
             pool.refresh(msdUUID, masterVersion)
+            self.validateSdUUID(msdUUID)
         except:
             self._disconnectPool(pool, pool.id, False)
             raise


-- 
To view, visit http://gerrit.ovirt.org/24568
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I27ab243a03f23b1155867f2eeec98b1481b5b72d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>


More information about the vdsm-patches mailing list