Change in vdsm[ovirt-3.4]: sp: stop all poolMonitoredDomains on disconnect

danken at redhat.com danken at redhat.com
Mon Feb 17 13:04:42 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: sp: stop all poolMonitoredDomains on disconnect
......................................................................


sp: stop all poolMonitoredDomains on disconnect

When we attempt to stop the DomainMonitor threads in StoragePool
we should use the poolMonitoredDomains list instead of using
getDomains.
Beside being more consistent and reliable it also fixes a race
in destroyStoragePool where we detach the last domain and then
we attempt to stop the remaining DomainMonitor.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1059757
Change-Id: Ibc77988b01491f687fd7afa6bb34512b5f2451af
Signed-off-by: Federico Simoncelli <fsimonce at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/24088
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Sergey Gotliv <sgotliv at redhat.com>
Reviewed-by: Ayal Baron <abaron at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/24546
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/storage/sp.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Federico Simoncelli: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/24546
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc77988b01491f687fd7afa6bb34512b5f2451af
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list