Change in vdsm[master]: introducing capability to stream data to image

nsoffer at redhat.com nsoffer at redhat.com
Mon Feb 17 11:46:10 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: introducing capability to stream data to image
......................................................................


Patch Set 12:

(1 comment)

http://gerrit.ovirt.org/#/c/23281/12/vdsm/storage/imageSharing.py
File vdsm/storage/imageSharing.py:

Line 17: # Refer to the README and COPYING files for full details of the license
Line 18: #
Line 19: 
Line 20: import logging
Line 21: import curlImgWrap
> Liron, I do not quite get why you keep the curlImgWrap with the stdlib impo
Do you suggest to import signal and socket after logging, and add a blank line before curlImgWrap?
Line 22: import signal
Line 23: import socket
Line 24: 
Line 25: from vdsm import constants


-- 
To view, visit http://gerrit.ovirt.org/23281
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I768b84799ed9fb2769c6d4240519d036f8988b99
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list