Change in vdsm[master]: introducing capability to stream data to image

nsoffer at redhat.com nsoffer at redhat.com
Sun Feb 16 17:25:33 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: introducing capability to stream data to image
......................................................................


Patch Set 11: Code-Review-1

(1 comment)

Missing return after header was missing.

http://gerrit.ovirt.org/#/c/23281/11/vdsm/BindingXMLRPC.py
File vdsm/BindingXMLRPC.py:

Line 147:                     if not all((spUUID, sdUUID, imgUUID)):
Line 148:                         self.send_error(httplib.BAD_REQUEST,
Line 149:                                         "missing or empty required header(s):"
Line 150:                                         " spUUID=%s sdUUID=%s imgUUID=%s"
Line 151:                                         % (spUUID, sdUUID, imgUUID))
You must return after sending error.
Line 152: 
Line 153:                     # Optional headers
Line 154:                     volUUID = self.headers.getheader(self.HEADER_VOLUME)
Line 155: 


-- 
To view, visit http://gerrit.ovirt.org/23281
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I768b84799ed9fb2769c6d4240519d036f8988b99
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list