Change in vdsm[ovirt-3.3]: vm iface statistics: never report negative rates

ybronhei at redhat.com ybronhei at redhat.com
Sun Feb 16 08:18:09 UTC 2014


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: vm iface statistics: never report negative rates
......................................................................


vm iface statistics: never report negative rates

When Linux tx/rx couters overflow their 32 bit limit, they wrap back to
zero. This causes our reported rxRate/txRate to become negative for one
nample. 51073875161d9b932b7

Bug-Url: https://bugzilla.redhat.com/1064489
Change-Id: I40daeb12172a7f54f135b3018405ef228983fa93
Signed-off-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/23598
Tested-by: Ondřej Svoboda <osvoboda at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/24152
Reviewed-by: Antoni Segura Puimedon <asegurap at redhat.com>
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/24322
---
M vdsm/vm.py
1 file changed, 4 insertions(+), 2 deletions(-)

Approvals:
  Yaniv Bronhaim: Looks good to me, approved
  Dan Kenigsberg: Verified; Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/24322
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I40daeb12172a7f54f135b3018405ef228983fa93
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list