Change in vdsm[master]: vm: recover must finish with libvirt connection

nsoffer at redhat.com nsoffer at redhat.com
Fri Feb 14 18:03:45 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: vm: recover must finish with libvirt connection
......................................................................


Patch Set 5:

(3 comments)

Some text issues.

http://gerrit.ovirt.org/#/c/24423/5//COMMIT_MSG
Commit Message:

Line 33: This patch excplitely handle this storage not responsive
Line 34: condition and let the initialization process continue, in
Line 35: order to make sure we obtain a libvirt handle.
Line 36: 
Line 37: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1063336
You can short this to https://bugzilla.redhat.com/1063336 (sadly this is not the canonical url).
Line 38: Change-Id: I6c33a62c29fc70170b6f802a20b6016b301e96de


http://gerrit.ovirt.org/#/c/24423/5/vdsm/vm.py
File vdsm/vm.py:

Line 2031:             except KeyError:
Line 2032:                 self.log.error("Unable to get volume size for %s",
Line 2033:                                drv['volumeID'], exc_info=True)
Line 2034:                 raise RuntimeError("Volume %s is corrupted or missing" %
Line 2035:                                    drv['volumeID'])
It is cool that your change is now minimal, but this RuntimeError and log seems unneeded now, as the caller can handle this exception and log the traceback. This can also can be handled in another patch.
Line 2036:         else:
Line 2037:             drv['truesize'] = 0
Line 2038:             drv['apparentsize'] = 0
Line 2039: 


Line 2104:                     self._normalizeVdsmImg(drv)
Line 2105:                 except StorageUnavailableError:
Line 2106:                     # storage unavailable is not fatal on recovery;
Line 2107:                     # the storage subsystem monitors the devices
Line 2108:                     # and them can bring back them online later.
"and them can bring back them online later" -> "and will notify when they come up later"
Line 2109:                     if not self.recovering:
Line 2110:                         raise
Line 2111: 
Line 2112:         self.normalizeDrivesIndices(devices[DISK_DEVICES])


-- 
To view, visit http://gerrit.ovirt.org/24423
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c33a62c29fc70170b6f802a20b6016b301e96de
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list