Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults (WIP)

asegurap at redhat.com asegurap at redhat.com
Thu Feb 13 14:54:50 UTC 2014


Antoni Segura Puimedon has posted comments on this change.

Change subject: netinfo: Retrieve bonding options differing from defaults (WIP)
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/24456/3/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:

Line 539: 
Line 540:     rc, _, err = execCmd([teeCmd, BONDING_MASTERS],
Line 541:                          data='+' + DUMMY_BOND, sudo=True)
Line 542:     if rc:
Line 543:         raise OSError('Creating a reference bond failed: %s.', err)
the err for OSError shoud be an errno. Generally it would fail due to EEXISTS or ENOPERM
Line 544: 
Line 545:     try:
Line 546:         opts = bondOpts(DUMMY_BOND)
Line 547:     finally:


-- 
To view, visit http://gerrit.ovirt.org/24456
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list