Change in vdsm[master]: api: domainDict is optional in connectStoragePool

nsoffer at redhat.com nsoffer at redhat.com
Thu Feb 13 12:12:18 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: api: domainDict is optional in connectStoragePool
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.ovirt.org/#/c/24089/1/vdsm_api/vdsmapi-schema.json
File vdsm_api/vdsmapi-schema.json:

Line 4251: # @masterVersion:  The Storage Domain version of the master domain
Line 4252: #
Line 4253: # @domainDict:     #optional The Storage Domain statuses (added in cluster
Line 4254: #                  level 3.4). If this argument is present the Storage Pool
Line 4255: #                  will use the memory backend (no metadata).
This is name is consistent with the schema (see reconstractMaster), but does not match the code (domainsMap). I suggest that we get this in now, and unify the names used in the schema and the code later.
Line 4256: #
Line 4257: # Since: 4.10.0
Line 4258: #
Line 4259: # Notes:  Only one Storage pool may be connected at a time


-- 
To view, visit http://gerrit.ovirt.org/24089
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I05b4f5073a33b2479404298ddafd4802e949e8f4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list