Change in vdsm[master]: hsm: encapsulate devPath in appropriateDevice

nsoffer at redhat.com nsoffer at redhat.com
Wed Feb 12 20:33:00 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: hsm: encapsulate devPath in appropriateDevice
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/24406/1/vdsm/clientIF.py
File vdsm/clientIF.py:

Line 270:                 # Update size for LUN volume
Line 271:                 drive["truesize"] = res['truesize']
Line 272:                 drive["apparentsize"] = res['apparentsize']
Line 273: 
Line 274:                 volPath = res['devPath']
Why not use "path" - just like prepareImage used for PDIV format?

We want to unify the names (appropriateDevice -> prepareDevice), and having both methods return a "path" key will make them more consistent and easier to use.
Line 275: 
Line 276:             # UUID drive format
Line 277:             elif "UUID" in drive:
Line 278:                 volPath = self._getUUIDSpecPath(drive["UUID"])


-- 
To view, visit http://gerrit.ovirt.org/24406
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf8f53999bde70eb4b2b1b0a927c9412d4597134
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list