Change in vdsm[master]: introducing capabillity to stream data to image

nsoffer at redhat.com nsoffer at redhat.com
Wed Feb 12 10:03:50 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: introducing capabillity to stream data to image
......................................................................


Patch Set 9:

(1 comment)

http://gerrit.ovirt.org/#/c/23281/9/vdsm/storage/imageSharing.py
File vdsm/storage/imageSharing.py:

Line 100:             p.stdin.write(data)
Line 101:             # Process stdin is not a real file object but a wrapper using
Line 102:             # StringIO buffer. To ensure that we don't use more memory if we
Line 103:             # get data faster then dd read it from the pipe, we flush on every
Line 104:             # write. We can remove if we can limit the buffer size used by
> Dan, how do you suggest to write the comment without "flush"? or did you me
Seems like replace "We can remove if" with "We can remove flush() if"
Line 105:             # this stdin wrapper.
Line 106:             p.stdin.flush()
Line 107:             bytes_left = bytes_left - len(data)
Line 108: 


-- 
To view, visit http://gerrit.ovirt.org/23281
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I768b84799ed9fb2769c6d4240519d036f8988b99
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list