Change in vdsm[ovirt-3.4]: fencing: stop using a deprecated command

danken at redhat.com danken at redhat.com
Tue Feb 11 17:24:01 UTC 2014


Hello Douglas Schilling Landgraf, Eli Mesika,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/24343

to review the following change.

Change subject: fencing: stop using a deprecated command
......................................................................

fencing: stop using a deprecated command

Recently, fence-agents stopped supporting the "option" alias for its
"action" STDIN command.

https://lists.fedorahosted.org/pipermail/cluster-commits/2013-February/003090.html

Let us conform to the new option name. The "action" name has been long
supported by el6 and f19's fence-agents, so it can be safely used.

Thanks to John Taylor for reporting the issue.

Bug-Url: https://bugzilla.redhat.com/1063472
Change-Id: Ia0e167e493412f95eda2325e0b028eb7c29c18bc
Signed-off-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/24303
Reviewed-by: Eli Mesika <emesika at redhat.com>
Reviewed-by: Douglas Schilling Landgraf <dougsland at redhat.com>
---
M vdsm/API.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/43/24343/1

diff --git a/vdsm/API.py b/vdsm/API.py
index 8c5b9cb..7cff71b 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -1142,7 +1142,7 @@
                 return errCode['fenceAgent']
             raise
 
-        inp = ('agent=fence_%s\nipaddr=%s\nlogin=%s\noption=%s\n'
+        inp = ('agent=fence_%s\nipaddr=%s\nlogin=%s\naction=%s\n'
                'passwd=%s\n') % (agent, addr, username, action, password)
         if port != '':
             inp += 'port=%s\n' % (port,)


-- 
To view, visit http://gerrit.ovirt.org/24343
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia0e167e493412f95eda2325e0b028eb7c29c18bc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>


More information about the vdsm-patches mailing list