Change in vdsm[master]: jsonrpc: Vdsm changes

smizrahi at redhat.com smizrahi at redhat.com
Tue Feb 11 11:00:48 UTC 2014


Saggi Mizrahi has posted comments on this change.

Change subject: jsonrpc: Vdsm changes
......................................................................


Patch Set 25:

(3 comments)

http://gerrit.ovirt.org/#/c/19497/25/lib/yajsonrpc/betterAsyncore.py
File lib/yajsonrpc/betterAsyncore.py:

Line 115:         return SSLSocket(SSL.Connection(context, sock=sock), self)
Line 116: 
Line 117: 
Line 118: # This is a copy of the standard library asyncore converted to support
Line 119: # compositing. Also fixes races in original implementation.
> just want explanation here.. what fixes?.. :/
the original implementation doesn't take the fifo lock at all the places it should.

It doesn't matter as this class is meant to be replaced later.
Line 120: class AsyncChat(object):
Line 121:     # these are overridable defaults
Line 122: 
Line 123:     ac_in_buffer_size = 4096


http://gerrit.ovirt.org/#/c/19497/25/lib/yajsonrpc/protonReactor.py
File lib/yajsonrpc/protonReactor.py:

Line 25: FAILED = 0
Line 26: CONNECTED = 1
Line 27: SERVER_AUTH = 2
Line 28: CLIENT_AUTH = 3
Line 29: 
> why 10?
Why not?
Line 30: MBUFF_SIZE = 10
Line 31: 
Line 32: 
Line 33: class ProtonError(RuntimeError):


http://gerrit.ovirt.org/#/c/19497/25/vdsm_api/BindingJsonRpc.py
File vdsm_api/BindingJsonRpc.py:

Line 72: 
Line 73:     def _createProtonListener(self, cfg):
Line 74:         address = cfg.get("host", "0.0.0.0")
Line 75:         port = cfg.get("port", 5672)
Line 76:         return self._reactors["amqp"].createListener((address, port))
> port is hardcoded?
http://docs.python.org/2/library/stdtypes.html#dict.get
Line 77: 
Line 78:     def _createTcpReactor(self, truststore_path=None):
Line 79:         if truststore_path is None:
Line 80:             return AsyncoreReactor()


-- 
To view, visit http://gerrit.ovirt.org/19497
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If828355b7efe28fe6a2e784069425fefd2f3f25c
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list