Change in vdsm[master]: tests: add initial tests for timeOffset handling

danken at redhat.com danken at redhat.com
Tue Feb 11 08:52:31 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: tests: add initial tests for timeOffset handling
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

timeOffset is still important for Windows guests, and imho also for certain Linux use cases. Thanks for adding the test.

http://gerrit.ovirt.org/#/c/24252/1/tests/vmTests.py
File tests/vmTests.py:

Line 637: class TestVmOperations(TestCaseBase):
Line 638:     BASE_OFFSET = 42
Line 639:     UPDATE_OFFSET = 3200  # just a number, no particular meaning
Line 640: 
Line 641:     @MonkeyPatch(constants, 'P_VDSM_RUN', '/tmp/')
please use tmpDir for this: some crazy systems may not have /tmp, and your current code forbid parallel execution by two users on the same host.
Line 642:     @MonkeyPatch(libvirtconnection, 'get', lambda x: ConnectionMock())
Line 643:     @permutations([[define.NORMAL], [define.ERROR]])
Line 644:     def testTimeOffsetRoundtrip(self, exitCode):
Line 645:         fake = vm.Vm(None, {'vmId': 'TESTING1',


-- 
To view, visit http://gerrit.ovirt.org/24252
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8925945686e6dd3a6a83a87e26157aba12ec1bd3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list