Change in vdsm[master]: vm: discover volume path from xml definition

danken at redhat.com danken at redhat.com
Tue Feb 11 00:32:33 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: vm: discover volume path from xml definition
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/24202/2//COMMIT_MSG
Commit Message:

Line 22:  domain
Line 23: 
Line 24: In this patch:
Line 25: 
Line 26: - revert to the previous path for virtual machine images
An explanation on the need to revert was not added.

But since this reversal is going to be just as harmful for current ovirt-3.3.1 users, as keeping the current path is for ovirt-3.3.0 upgrading, I am not sure that we should take that path.

How about splitting this to a different patch, and considering to use it only on systems with a big fleet of running vm that use the /rhev/dc/spUUID path.
Line 27: - inspect libvirt xml during live migration and vdsm restart to
Line 28:   identify if it is necessary to update the path cached in the
Line 29:   drive object (provided by prepareImage)
Line 30: 


-- 
To view, visit http://gerrit.ovirt.org/24202
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I322f1f879fbd5b6415789f3b307e8741d846d694
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list