Change in vdsm[master]: xmlrpc: Use correct base class for parsing request

nsoffer at redhat.com nsoffer at redhat.com
Mon Feb 10 17:22:50 UTC 2014


Nir Soffer has uploaded a new change for review.

Change subject: xmlrpc: Use correct base class for parsing request
......................................................................

xmlrpc: Use correct base class for parsing request

Previously we always used SecureXMLRPCServer.parse_request, even when
using SimpleXMLRPCServer. That happened to work since both inherit
parse_request from BaseHTTPServer. This patch use the correct base
class, so if one of them will override parse_request, we use the correct
method.

Change-Id: I4ef737c02afb97580179f381e0f227ee94e1383f
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
---
M vdsm/BindingXMLRPC.py
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/89/24289/1

diff --git a/vdsm/BindingXMLRPC.py b/vdsm/BindingXMLRPC.py
index b71dae5..7308c5c 100644
--- a/vdsm/BindingXMLRPC.py
+++ b/vdsm/BindingXMLRPC.py
@@ -109,8 +109,7 @@
                 return basehandler.setup(self)
 
             def parse_request(self):
-                r = (SecureXMLRPCServer.SecureXMLRPCRequestHandler.
-                     parse_request(self))
+                r = basehandler.parse_request(self)
                 threadLocal.flowID = self.headers.get(HTTP_HEADER_FLOWID)
                 return r
 


-- 
To view, visit http://gerrit.ovirt.org/24289
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4ef737c02afb97580179f381e0f227ee94e1383f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>


More information about the vdsm-patches mailing list