Change in vdsm[master]: tests: validate cdrom path sent to/received from vdsm

fromani at redhat.com fromani at redhat.com
Mon Feb 10 13:30:56 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: tests: validate cdrom path sent to/received from vdsm
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.ovirt.org/#/c/22194/3/tests/functional/virtTests.py
File tests/functional/virtTests.py:

Line 283: 
Line 284:         # echo -n testPayload | md5sum
Line 285:         # d37e46c24c78b1aed33496107afdb44b
Line 286:         vmPayloadName = ('/var/run/vdsm/payload/{}.d37e46c24c78b1aed33496'
Line 287:                          '107afdb44b.img').format(customization['vmId'])
nit: I'd not break the md5sum as it is done now, but it is personal taste so it can stay like that.
Line 288: 
Line 289:         cdrom = {'index': '2', 'iface': 'ide', 'specParams':
Line 290:                  {}, 'readonly': 'true', 'path':
Line 291:                  '', 'device': 'cdrom', 'shared':


Line 290:                  {}, 'readonly': 'true', 'path':
Line 291:                  '', 'device': 'cdrom', 'shared':
Line 292:                  'false', 'type': 'disk'}
Line 293: 
Line 294:         with temporaryPath(0x666) as path:
nit: octal is probably better here: 0o666 like elsewhere temporaryPath is used.
Line 295:             cdromPaths = {'self': {'path': path, 'specParams':
Line 296:                                    {'path': '/dev/null'}},
Line 297:                           'specParams': {'path': '', 'specParams':
Line 298:                                          {'path': path}},


-- 
To view, visit http://gerrit.ovirt.org/22194
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I620c481056f7ee3b4d3270ba1f4bc45cbb132ebb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list