Change in vdsm[master]: clientIF: prepareVolumePath payload cleanup
asegurap at redhat.com
asegurap at redhat.com
Mon Feb 10 11:39:09 UTC 2014
Antoni Segura Puimedon has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
......................................................................
Patch Set 6:
(2 comments)
http://gerrit.ovirt.org/#/c/22928/6/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 315: self.log.info("prepared volume path: %s", volPath)
Line 316: return volPath
Line 317:
Line 318: def _prepareVolumeFromPayload(self, vmId, drive, device, payload):
Line 319: '''
s/'''/"""/
Line 320: vmPayload is a key in params
Line 321: 'vmPayload': {'volId': 'volume id', # volId is optional
Line 322: 'file': {'filename': 'content', ...}}
Line 323: '''
Line 330:
Line 331: try:
Line 332: mkFsFunction = getattr(supervdsm.getProxy(),
Line 333: mkFsNames[device])
Line 334: except RuntimeError:
Can you elaborate on the change of checking for RuntimeError (very generic) instead of AttributeError
Line 335: raise vm.VolumeError("Supervdsm call failed for %s in "
Line 336: "drive: %s" % (device, drive))
Line 337:
Line 338: return mkFsFunction(vmId, payload['file'], payload.get('volId'))
--
To view, visit http://gerrit.ovirt.org/22928
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a630d74ec0910c669e0326ad343c5dbea25357e
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list