Change in vdsm[master]: tests: validate cdrom path sent to/received from vdsm

Federico Simoncelli fsimonce at redhat.com
Mon Feb 10 11:19:39 UTC 2014


Federico Simoncelli has posted comments on this change.

Change subject: tests: validate cdrom path sent to/received from vdsm
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/22194/2/tests/functional/virtTests.py
File tests/functional/virtTests.py:

Line 283: 
Line 284:         customization = {'vmId': '77777777-ffff-3333-bbbb-222222222222',
Line 285:                          'vmName': 'testVm', 'devices': [cdrom]}
Line 286: 
Line 287:         if (pathLocation == 'self'):
Can you look at the previous test (deviceDef). Maybe you can use the same approach here as well.
Line 288:             cdrom['path'] = path
Line 289:             cdrom['specParams']['path'] = '/dev/null'
Line 290:         elif (pathLocation == 'specParams'):
Line 291:             cdrom['path'] = ''


-- 
To view, visit http://gerrit.ovirt.org/22194
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I620c481056f7ee3b4d3270ba1f4bc45cbb132ebb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list