Change in vdsm[master]: tests: validate cdrom path sent to/received from vdsm

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Mon Feb 10 11:16:06 UTC 2014


Michal Skrivanek has posted comments on this change.

Change subject: tests: validate cdrom path sent to/received from vdsm
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/22194/2/tests/functional/virtTests.py
File tests/functional/virtTests.py:

Line 272:                                          deviceDef['hotplugDisk']), timeout=10)
Line 273: 
Line 274:     @permutations([['self'], ['specParams'], ['vmPayload']])
Line 275:     def testVmWithCdrom(self, pathLocation):
Line 276:         fd, path = tempfile.mkstemp()
do we remove the file on failures?
Line 277:         os.chmod(path, 0o644)
Line 278: 
Line 279:         cdrom = {'index': '2', 'iface': 'ide', 'specParams':
Line 280:                  {}, 'readonly': 'true', 'path':


-- 
To view, visit http://gerrit.ovirt.org/22194
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I620c481056f7ee3b4d3270ba1f4bc45cbb132ebb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list