Change in vdsm[master]: xmlrpc: Fix connection reset on Python 2.6

asegurap at redhat.com asegurap at redhat.com
Mon Feb 10 10:16:06 UTC 2014


Antoni Segura Puimedon has posted comments on this change.

Change subject: xmlrpc: Fix connection reset on Python 2.6
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/24026/1/lib/vdsm/utils.py
File lib/vdsm/utils.py:

Line 159:                                     bind_and_activate)
Line 160: 
Line 161:     # Fix for connection reset issue when running on Python 2.6. This happens
Line 162:     # when request is aborted before the reading the entire request. Closing
Line 163:     # the socket cause the other side to receive connection reset, and loose
s/loose/lose/
Line 164:     # the response data.  Python 2.7 introduced the shutdown_request method,
Line 165:     # fixing this issue. If we run on a version without this method, we will do
Line 166:     # a clean shutdown in close_request instead.
Line 167:     if not hasattr(SimpleXMLRPCServer, 'shutdown_request'):


-- 
To view, visit http://gerrit.ovirt.org/24026
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id77a32bb0d4fff13ee680eade52a2f60e4e808b5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list