Change in vdsm[master]: vm: Require format attribute for drives

nsoffer at redhat.com nsoffer at redhat.com
Sun Feb 9 13:14:01 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: vm: Require format attribute for drives
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/24234/1/vdsm/vm.py
File vdsm/vm.py:

Line 1441:     VOLWM_FREE_PCT = 100 - config.getint('irs', 'volume_utilization_percent')
Line 1442:     VOLWM_CHUNK_REPLICATE_MULT = 2  # Chunk multiplier during replication
Line 1443: 
Line 1444:     def __init__(self, conf, log, **kwargs):
Line 1445:         if 'format' not in kwargs:
> can't we put a default value instead of raising an exception?
We can, but this will hide the faulty code calling us without a required parameter, which we like to fix.
Line 1446:             raise InvalidDeviceParameters('"format" attribute is required:'
Line 1447:                                           ' %r' % kwargs)
Line 1448:         if not kwargs.get('serial'):
Line 1449:             self.serial = kwargs.get('imageID'[-20:]) or ''


-- 
To view, visit http://gerrit.ovirt.org/24234
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I01ab1e071ecb76f383cc6dc7d99782e10cc90136
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Meital Bourvine <mbourvin at redhat.com>
Gerrit-Reviewer: Meital bourvine <meitalbourvine at gmail.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list