Change in vdsm[master]: execCmd: no need to pass the default sudo=False value

vfeenstr at redhat.com vfeenstr at redhat.com
Fri Feb 7 08:39:35 UTC 2014


Vinzenz Feenstra has posted comments on this change.

Change subject: execCmd: no need to pass the default sudo=False value
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.ovirt.org/#/c/24145/2/vdsm/storage/blockSD.py
File vdsm/storage/blockSD.py:

Line 217: ioclass
> This can be two lines now instead of three
Done


http://gerrit.ovirt.org/#/c/24145/2/vdsm/storage/clusterlock.py
File vdsm/storage/clusterlock.py:

Line 64: 
Line 65:     def initLock(self):
Line 66:         lockUtil = os.path.join(self.lockUtilPath, "safelease")
Line 67:         initCommand = [lockUtil, "release", "-f", self._leasesPath, "0"]
Line 68:         rc, out, err = misc.execCmd(initCommand,
> Fits into one line now
Done
Line 69:                                     cwd=self.lockUtilPath)
Line 70:         if rc != 0:
Line 71:             self.log.warn("could not initialise spm lease (%s): %s", rc, out)
Line 72:             raise se.ClusterLockInitError()


http://gerrit.ovirt.org/#/c/24145/2/vdsm/storage/volume.py
File vdsm/storage/volume.py:

Line 1032:         # can also accept size in M or G with appropriate suffix
Line 1033:         # +1 is so that odd numbers will round upwards.
Line 1034:         cmd += [volume, "%uK" % ((size + 1) / 2)]
Line 1035: 
Line 1036:     (rc, out, err) = misc.execCmd(cmd, cwd=cwd,
> Fits into one line now
Done
Line 1037:                                   deathSignal=signal.SIGKILL)
Line 1038:     if rc:
Line 1039:         raise se.VolumeCreationError(out)
Line 1040:     return True


-- 
To view, visit http://gerrit.ovirt.org/24145
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id8c0e30756113ddb35d2e51984c3ea72bbe45a44
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list