Change in vdsm[master]: vmDevices: add __slots__ to devices

nsoffer at redhat.com nsoffer at redhat.com
Thu Feb 6 22:48:12 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: vmDevices: add __slots__ to devices
......................................................................


Patch Set 5:

(1 comment)

Related bug

http://gerrit.ovirt.org/#/c/21036/5//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: VDSM devices are created using setattr over **kwargs, making the
Line 10: initialization implicit. Implementing __slots__ does define which
Line 11: attributes does the device accept and also slightly improves memory footprint.
Line 12: 
Please add related bug:

    Releates-To: https://bugzilla.redhat.com/1055437
Line 13: Change-Id: I6e8dadabdd02d3b44606f215c4bc7b7e306a591a


-- 
To view, visit http://gerrit.ovirt.org/21036
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e8dadabdd02d3b44606f215c4bc7b7e306a591a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list