Change in vdsm[master]: netinfo: Fix wrong filtering of dummy devices

danken at redhat.com danken at redhat.com
Thu Feb 6 17:55:18 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: netinfo: Fix wrong filtering of dummy devices
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

I need more explanation in the commit message.

http://gerrit.ovirt.org/#/c/24175/1//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: Dummy (and veth) devices were being filtered for use by vdsm in the
Line 10: method isFakeNic, but in the method that is used to determine what
Line 11: is reported as nics, isNicLike, it was not being used, and instead
Line 12: isDUMMY and isVETH were being called.
And for short: before this patch, any veth device is reported as a nic; now only explicitly-faked one would.
Line 13: 
Line 14: Change-Id: I3809eb1bb3230543bd586dcf722e2603da16952a


-- 
To view, visit http://gerrit.ovirt.org/24175
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3809eb1bb3230543bd586dcf722e2603da16952a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list