Change in vdsm[master]: execCmd: no need to pass the default sudo=False value

vfeenstr at redhat.com vfeenstr at redhat.com
Thu Feb 6 10:52:25 UTC 2014


Vinzenz Feenstra has posted comments on this change.

Change subject: execCmd: no need to pass the default sudo=False value
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/24145/1//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: These are remnants from the days where we had a crazier default.
Line 10: Cleaned with
Line 11:      sed -i 's/execCmd\(.*\), sudo=False/execCmd\1/'
Line 12: and a couple of manual additions.
> I don't understand the reason for it . we still use the sudo parameter, and
This patch is removing all the specification of sudo=False in the usage of execCmd, which is now the default.
Line 13: 
Line 14: Change-Id: Id8c0e30756113ddb35d2e51984c3ea72bbe45a44


-- 
To view, visit http://gerrit.ovirt.org/24145
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id8c0e30756113ddb35d2e51984c3ea72bbe45a44
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list