Change in vdsm[master]: spec: vdsm pkg for EL distro must include pkla

danken at redhat.com danken at redhat.com
Wed Feb 5 18:24:47 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: spec: vdsm pkg for EL distro must include pkla
......................................................................


Patch Set 4: Code-Review-1

(2 comments)

http://gerrit.ovirt.org/#/c/24083/4/vdsm.spec.in
File vdsm.spec.in:

Line 661: # dropbox for core dumps
Line 662: install -dDm 1777 %{buildroot}%{_localstatedir}/log/core
Line 663: %endif
Line 664: 
Line 665: %if 0%{?fedora}
could you keep the former

   if ! 0%{rhel}

? Breaking the "%if" is fine, but not the introduction of %fedora.
Line 666: # Install the configuration sample
Line 667: install -Dm 0644 lib/vdsm/vdsm.conf.sample \
Line 668:                  %{buildroot}%{_sysconfdir}/%{vdsm_name}/vdsm.conf
Line 669: %endif


Line 933: %{_datadir}/%{vdsm_name}/vdsm-restore-net-config
Line 934: %{_datadir}/%{vdsm_name}/vdsm-store-net-config
Line 935: %{_datadir}/%{vdsm_name}/vm.py*
Line 936: 
Line 937: %if 0%{?fedora}
this move belongs to its own patch.
Line 938: %config(noreplace) %{_sysconfdir}/%{vdsm_name}/vdsm.conf
Line 939: %endif
Line 940: %config(noreplace) %{_sysconfdir}/%{vdsm_name}/logger.conf
Line 941: %config(noreplace) %{_sysconfdir}/%{vdsm_name}/svdsm.logger.conf


-- 
To view, visit http://gerrit.ovirt.org/24083
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I298f21ee6a3e5f2fdf78939ea421a2152490972b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list